Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Remove workaround for broken cc version #2044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(ci): Remove workaround for broken cc version #2044

wants to merge 1 commit into from
+0 −5

Conversation

matheus23
Copy link
Contributor

We've previously had this workaround in CI for cc versions between version 1.1.32 and 1.1.37 which broke the ring build for wasm32-unknown-unknown in github actions.

Version 1.2.0 is now released and doesn't break ring anymore.

Related PRs:

djc
djc approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we force the use of cc 1.2 via a dependency requirement?

@matheus23
Copy link
Contributor Author

Honestly, I'm not sure. I've only seen these tests break in github actions so far.

Locally, running the cargo tests for wasm32-unknown-unknown with cc version 1.1.32-37 was just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheus23 @djc